ondra/ironmount
1
1
Fork 0
mirror of https://github.com/nicotsx/ironmount.git synced 2025-12-10 12:10:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

avoid logging secrets in smb backend

Browse Source
This commit is contained in:
Jakub Trávník
2025-12-04 08:33:55 +01:00
committed by Nicolas Meienberger
parent 2df1fa53a0
commit 1fe026a76f
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
app/server/modules/backends/smb/smb-backend.ts
View File

@@ -37,9 +37,8 @@ const mount = async (config: BackendConfig, path: string) => {
const password = await cryptoUtils.decrypt(config.password); const password = await cryptoUtils.decrypt(config.password);
const source = `//${config.server}/${config.share}`; const source = `//${config.server}/${config.share}`;
const options = [ const baseOptions = [
`user=${config.username}`, `user=${config.username}`,
`pass=${password}`,
`vers=${config.vers}`, `vers=${config.vers}`,
`port=${config.port}`, `port=${config.port}`,
"uid=1000", "uid=1000",
@@ -47,18 +46,22 @@ const mount = async (config: BackendConfig, path: string) => {
]; ];
if (config.domain) { if (config.domain) {
options.push(`domain=${config.domain}`); baseOptions.push(`domain=${config.domain}`);
} }
if (config.readOnly) { if (config.readOnly) {
options.push("ro"); baseOptions.push("ro");
} }
const args = ["-t", "cifs", "-o", options.join(","), source, path]; const baseArgs = ["-t", "cifs", "-o"];
logger.debug(`Mounting SMB volume ${path}...`); logger.debug(`Mounting SMB volume ${path}...`);
logger.info(`Executing mount: mount ${args.join(" ")}`); const safeOptions = [...baseOptions, "pass=***"];
const safeArgs = [...baseArgs, safeOptions.join(","), source, path];
logger.info(`Executing mount: mount ${safeArgs.join(" ")}`);
const options = [...baseOptions, `pass=${password}`];
const args = [...baseArgs, options.join(","), source, path];
await executeMount(args); await executeMount(args);
logger.info(`SMB volume at ${path} mounted successfully.`); logger.info(`SMB volume at ${path} mounted successfully.`);