feat: mount / unmount

apps/server/src/modules/backends/directory/directory-backend.ts

@@ -2,14 +2,15 @@ import * as fs from "node:fs/promises";
 import * as npath from "node:path";
 import { BACKEND_STATUS, type BackendConfig } from "@ironmount/schemas";
 import type { VolumeBackend } from "../backend";
+import { logger } from "../../../utils/logger";
 
 const mount = async (_config: BackendConfig, path: string) => {
-	console.log("Mounting directory volume...");
+	logger.info("Mounting directory volume...");
 	await fs.mkdir(path, { recursive: true });
 };
 
 const unmount = async () => {
-	console.log("Cannot unmount directory volume.");
+	logger.info("Cannot unmount directory volume.");
 };
 
 const checkHealth = async (path: string) => {
@@ -23,7 +24,7 @@ const checkHealth = async (path: string) => {
 
 		return { status: BACKEND_STATUS.mounted };
 	} catch (error) {
-		console.error("Directory health check failed:", error);
+		logger.error("Directory health check failed:", error);
 		return { status: BACKEND_STATUS.error, error: error instanceof Error ? error.message : String(error) };
 	}
 };

apps/server/src/modules/backends/nfs/nfs-backend.ts

@@ -4,6 +4,7 @@ import * as os from "node:os";
 import * as npath from "node:path";
 import { BACKEND_STATUS, type BackendConfig } from "@ironmount/schemas";
 import type { VolumeBackend } from "../backend";
+import { logger } from "../../../utils/logger";
 
 const mount = async (config: BackendConfig, path: string) => {
 	if (config.backend !== "nfs") {
@@ -11,7 +12,7 @@ const mount = async (config: BackendConfig, path: string) => {
 	}
 
 	if (os.platform() !== "linux") {
-		console.error("NFS mounting is only supported on Linux hosts.");
+		logger.error("NFS mounting is only supported on Linux hosts.");
 		return;
 	}
 
@@ -27,14 +28,14 @@ const mount = async (config: BackendConfig, path: string) => {
 		}, 5000);
 
 		exec(cmd, (error, stdout, stderr) => {
-			console.log("Mount command executed:", { cmd, error, stdout, stderr });
+			logger.info("Mount command executed:", { cmd, error, stdout, stderr });
 			clearTimeout(timeout);
 
 			if (error) {
-				console.error(`Error mounting NFS volume: ${stderr}`);
+				logger.error(`Error mounting NFS volume: ${stderr}`);
 				return reject(new Error(`Failed to mount NFS volume: ${stderr}`));
 			}
-			console.log(`NFS volume mounted successfully: ${stdout}`);
+			logger.info(`NFS volume mounted successfully: ${stdout}`);
 			resolve();
 		});
 	});
@@ -42,7 +43,14 @@ const mount = async (config: BackendConfig, path: string) => {
 
 const unmount = async (path: string) => {
 	if (os.platform() !== "linux") {
-		console.error("NFS unmounting is only supported on Linux hosts.");
+		logger.error("NFS unmounting is only supported on Linux hosts.");
+		return;
+	}
+
+	try {
+		await fs.access(path);
+	} catch {
+		logger.warn(`Path ${path} does not exist. Skipping unmount.`);
 		return;
 	}
 
@@ -54,14 +62,14 @@ const unmount = async (path: string) => {
 		}, 5000);
 
 		exec(cmd, (error, stdout, stderr) => {
-			console.log("Unmount command executed:", { cmd, error, stdout, stderr });
+			logger.info("Unmount command executed:", { cmd, error, stdout, stderr });
 			clearTimeout(timeout);
 
 			if (error) {
-				console.error(`Error unmounting NFS volume: ${stderr}`);
+				logger.error(`Error unmounting NFS volume: ${stderr}`);
 				return reject(new Error(`Failed to unmount NFS volume: ${stderr}`));
 			}
-			console.log(`NFS volume unmounted successfully: ${stdout}`);
+			logger.info(`NFS volume unmounted successfully: ${stdout}`);
 			resolve();
 		});
 	});
@@ -78,7 +86,7 @@ const checkHealth = async (path: string) => {
 
 		return { status: BACKEND_STATUS.mounted };
 	} catch (error) {
-		console.error("NFS volume health check failed:", error);
+		logger.error("NFS volume health check failed:", error);
 		return { status: BACKEND_STATUS.error, error: error instanceof Error ? error.message : String(error) };
 	}
 };

apps/server/src/modules/volumes/volume.controller.ts

@@ -13,8 +13,11 @@ import {
 	updateVolumeBody,
 	updateVolumeDto,
 	type VolumeDto,
+	mountVolumeDto,
+	unmountVolumeDto,
 } from "./volume.dto";
 import { volumeService } from "./volume.service";
+import { logger } from "../../utils/logger";
 
 export const volumeController = new Hono()
 	.get("/", listVolumesDto, async (c) => {
@@ -100,4 +103,26 @@ export const volumeController = new Hono()
 		};
 
 		return c.json(response, 200);
+	})
+	.post("/:name/mount", mountVolumeDto, async (c) => {
+		const { name } = c.req.param();
+		const res = await volumeService.mountVolume(name);
+
+		if (res.error) {
+			const { message, status } = handleServiceError(res.error);
+			return c.json(message, status);
+		}
+
+		return c.json({ message: "Volume mounted successfully" }, 200);
+	})
+	.post("/:name/unmount", unmountVolumeDto, async (c) => {
+		const { name } = c.req.param();
+		const res = await volumeService.unmountVolume(name);
+
+		if (res.error) {
+			const { message, status } = handleServiceError(res.error);
+			return c.json(message, status);
+		}
+
+		return c.json({ message: "Volume unmounted successfully" }, 200);
 	});

apps/server/src/modules/volumes/volume.dto.ts

@@ -190,3 +190,57 @@ export const testConnectionDto = describeRoute({
 		},
 	},
 });
+
+/**
+ * Mount volume
+ */
+export const mountVolumeResponse = type({
+	message: "string",
+});
+
+export const mountVolumeDto = describeRoute({
+	description: "Mount a volume",
+	operationId: "mountVolume",
+	validateResponse: true,
+	tags: ["Volumes"],
+	responses: {
+		200: {
+			description: "Volume mounted successfully",
+			content: {
+				"application/json": {
+					schema: resolver(mountVolumeResponse),
+				},
+			},
+		},
+		404: {
+			description: "Volume not found",
+		},
+	},
+});
+
+/**
+ * Unmount volume
+ */
+export const unmountVolumeResponse = type({
+	message: "string",
+});
+
+export const unmountVolumeDto = describeRoute({
+	description: "Unmount a volume",
+	operationId: "unmountVolume",
+	validateResponse: true,
+	tags: ["Volumes"],
+	responses: {
+		200: {
+			description: "Volume unmounted successfully",
+			content: {
+				"application/json": {
+					schema: resolver(unmountVolumeResponse),
+				},
+			},
+		},
+		404: {
+			description: "Volume not found",
+		},
+	},
+});

apps/server/src/modules/volumes/volume.service.ts

@@ -9,6 +9,7 @@ import { config } from "../../core/config";
 import { db } from "../../db/db";
 import { volumesTable } from "../../db/schema";
 import { createVolumeBackend } from "../backends/backend";
+import { logger } from "../../utils/logger";
 
 const listVolumes = async () => {
 	const volumes = await db.query.volumesTable.findMany({});
@@ -76,7 +77,18 @@ const mountVolume = async (name: string) => {
 		}
 
 		const backend = createVolumeBackend(volume);
+		await backend.unmount().catch((_) => {
+			// Ignore unmount errors
+		});
+
 		await backend.mount();
+
+		await db
+			.update(volumesTable)
+			.set({ status: "mounted", lastHealthCheck: new Date() })
+			.where(eq(volumesTable.name, name));
+
+		return { status: 200 };
 	} catch (error) {
 		return {
 			error: new InternalServerError("Failed to mount volume", {
@@ -86,6 +98,34 @@ const mountVolume = async (name: string) => {
 	}
 };
 
+const unmountVolume = async (name: string) => {
+	try {
+		const volume = await db.query.volumesTable.findFirst({
+			where: eq(volumesTable.name, name),
+		});
+
+		if (!volume) {
+			return { error: new NotFoundError("Volume not found") };
+		}
+
+		const backend = createVolumeBackend(volume);
+		await backend.unmount();
+
+		await db
+			.update(volumesTable)
+			.set({ status: "unmounted", lastHealthCheck: new Date() })
+			.where(eq(volumesTable.name, name));
+
+		return { status: 200 };
+	} catch (error) {
+		return {
+			error: new InternalServerError("Failed to unmount volume", {
+				cause: error,
+			}),
+		};
+	}
+};
+
 const getVolume = async (name: string) => {
 	const volume = await db.query.volumesTable.findFirst({
 		where: eq(volumesTable.name, name),
@@ -202,7 +242,7 @@ const testConnection = async (backendConfig: BackendConfig) => {
 				await fs.rm(tempDir, { recursive: true, force: true });
 			} catch (cleanupError) {
 				// Ignore cleanup errors if directory doesn't exist or can't be removed
-				console.warn("Failed to cleanup temp directory:", cleanupError);
+				logger.warn("Failed to cleanup temp directory:", cleanupError);
 			}
 		}
 	}
@@ -218,4 +258,5 @@ export const volumeService = {
 	testConnection,
 	updateVolumeStatus,
 	getVolumeStatus,
+	unmountVolume,
 };