fix(smtp-notification): always use smtp://

README.md

@@ -6,7 +6,7 @@
   </a>
   <br />
   <figure>
-    <img src="https://github.com/nicotsx/zerobyte/blob/main/screenshots/backup-details.png?raw=true" alt="Demo" />
+    <img src="https://github.com/nicotsx/zerobyte/blob/main/screenshots/backup-details.webp?raw=true" alt="Demo" />
     <figcaption>
       <p align="center">
         Backup management with scheduling and monitoring

app/server/modules/backups/backups.service.ts

@@ -238,6 +238,7 @@ const executeBackup = async (scheduleId: number, manual = false) => {
 
 		await restic.backup(repository.config, volumePath, {
 			...backupOptions,
+			compressionMode: repository.compressionMode ?? "auto",
 			onProgress: (progress) => {
 				serverEvents.emit("backup:progress", {
 					scheduleId,

app/server/modules/notifications/builders/email.ts

@@ -1,10 +1,10 @@
 import type { NotificationConfig } from "~/schemas/notifications";
 
 export function buildEmailShoutrrrUrl(config: Extract<NotificationConfig, { type: "email" }>): string {
-	const protocol = config.useTLS ? "smtps" : "smtp";
 	const auth = `${encodeURIComponent(config.username)}:${encodeURIComponent(config.password)}`;
 	const host = `${config.smtpHost}:${config.smtpPort}`;
 	const toRecipients = config.to.map((email) => encodeURIComponent(email)).join(",");
+	const useStartTLS = config.useTLS ? "yes" : "no";
 
-	return `${protocol}://${auth}@${host}/?from=${encodeURIComponent(config.from)}&to=${toRecipients}`;
+	return `smtp://${auth}@${host}/?from=${encodeURIComponent(config.from)}&to=${toRecipients}&starttls=${useStartTLS}`;
 }

app/server/utils/restic.ts

@@ -9,7 +9,7 @@ import { logger } from "./logger";
 import { cryptoUtils } from "./crypto";
 import type { RetentionPolicy } from "../modules/backups/backups.dto";
 import { safeSpawn } from "./spawn";
-import type { RepositoryConfig } from "~/schemas/restic";
+import type { CompressionMode, RepositoryConfig } from "~/schemas/restic";
 
 const backupOutputSchema = type({
 	message_type: "'summary'",
@@ -234,6 +234,7 @@ const backup = async (
 		exclude?: string[];
 		include?: string[];
 		tags?: string[];
+		compressionMode?: CompressionMode;
 		signal?: AbortSignal;
 		onProgress?: (progress: BackupProgress) => void;
 	},
@@ -241,7 +242,14 @@ const backup = async (
 	const repoUrl = buildRepoUrl(config);
 	const env = await buildEnv(config);
 
-	const args: string[] = ["--repo", repoUrl, "backup", "--one-file-system"];
+	const args: string[] = [
+		"--repo",
+		repoUrl,
+		"backup",
+		"--one-file-system",
+		"--compression",
+		options?.compressionMode ?? "auto",
+	];
 
 	if (options?.tags && options.tags.length > 0) {
 		for (const tag of options.tags) {
@@ -291,6 +299,7 @@ const backup = async (
 
 	let stdout = "";
 
+	logger.debug(`Executing: restic ${args.join(" ")}`);
 	const res = await safeSpawn({
 		command: "restic",
 		args,